Fix getitem and list comprehension type inference.#4282
Merged
robertwb merged 1 commit intoapache:masterfrom Dec 19, 2017
Merged
Fix getitem and list comprehension type inference.#4282robertwb merged 1 commit intoapache:masterfrom
robertwb merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
charlesccychen
approved these changes
Dec 18, 2017
Contributor
charlesccychen
left a comment
charlesccychen
left a comment
There was a problem hiding this comment.
Thanks, this LGTM.
robertwb
force-pushed
the
type-inference
branch
from
c8e5ff3 to
8103010
Compare
robertwb
added a commit
to robertwb/incubator-beam
that referenced
this pull request
Dec 19, 2017
This gets the tests passing (and fixes the lint error). A more principled fix will be in a follow-up PR.
Alienero
pushed a commit
to Alienero/beam
that referenced
this pull request
Dec 21, 2017
This gets the tests passing (and fixes the lint error). A more principled fix will be in a follow-up PR.
nguyent
pushed a commit
to nguyent/beam
that referenced
this pull request
Dec 29, 2017
This gets the tests passing (and fixes the lint error). A more principled fix will be in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.